Open
Conversation
smangels
commented
Mar 1, 2019
smangels
commented
- provides a docker-compose file which makes it much easier to start your own rune server
- requires docker-compose
added 3 commits
March 1, 2019 01:48
- makes it much easier to run a roon server - docker-compose is required - don't forget to map the musci folder to a path on your local machine
- supported from docker-compose 3.7 - allows roon server to receiving stop signals, service isn't killed anymore - improves shutdown process a lot
steefdebruijn
requested changes
Mar 5, 2019
Owner
steefdebruijn
left a comment
steefdebruijn
left a comment
There was a problem hiding this comment.
Hi,
Thanks for the addition.
However, the proposed setup requires/triggers? local build of docker image which is unnecessary and breaks current usage for me (this GIT repo is auto-compiled to docker-hub from where it can be pulled, in my case by systemd service).
Can the docker-compose be changed so it is a drop-in example which uses the docker-hub image (and the existing files placed back to their original location)? I think that enables both usage scenarios. README should address this too.
Again thanks for the contribution,
Steef
Author
|
I fully agree, let me think through it and return with a more suitable commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.